Formalize integer division and CIntegers in the metatheory - #7864
Open
ana-pantilie wants to merge 5 commits into
Open
Formalize integer division and CIntegers in the metatheory#7864ana-pantilie wants to merge 5 commits into
ana-pantilie wants to merge 5 commits into
Conversation
ana-pantilie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/IntersectMBO/plutus-private/issues/2356
Also adds some new conformance tests which check the integer bounds as well. I believe that since these are conformance tests, they should be as exhaustive as possible. So I should have added underflow tests for all inputs (not just the first), overflow tests for all inputs (not just the second) and tests which check that when the inputs are equal to the lower/upper bound the scripts don't error. @kwxm what do you think? I can add them as a separate PR if you agree.